Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(input): value and onChange prop is optional #228

Merged
merged 1 commit into from
Sep 17, 2020
Merged

feat(input): value and onChange prop is optional #228

merged 1 commit into from
Sep 17, 2020

Conversation

LEEHONCN
Copy link
Contributor

@LEEHONCN LEEHONCN commented Sep 17, 2020

affects: @gio-design/components, website

ISSUES CLOSED: #217

Related issue link

#217

Changelog

value and onChange prop is optional

Language Changelog
🇺🇸 English value and onChange prop is optional
🇨🇳 Chinese value和 onChange 参数是可选的

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@azure-pipelines
Copy link

Deploy preview for gio-design failed.

affects: @gio-design/components, website

ISSUES CLOSED: #217
@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #228 into master will decrease coverage by 7.06%.
The diff coverage is 21.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #228      +/-   ##
==========================================
- Coverage   70.02%   62.96%   -7.07%     
==========================================
  Files          90       95       +5     
  Lines        2392     2762     +370     
  Branches      611      686      +75     
==========================================
+ Hits         1675     1739      +64     
- Misses        713     1019     +306     
  Partials        4        4              
Impacted Files Coverage Δ
...ckages/components/src/components/select/Select.tsx 0.00% <0.00%> (ø)
...mponents/src/components/tree-select/TreeSelect.tsx 0.00% <0.00%> (ø)
packages/components/src/components/tree/Tree.tsx 0.00% <0.00%> (ø)
...ckages/components/src/components/tree/iconUtil.tsx 0.00% <ø> (ø)
packages/components/src/utils/iconUtil.tsx 0.00% <0.00%> (ø)
...nts/src/components/date-picker/dateRangePicker.tsx 18.18% <18.18%> (ø)
...es/components/src/components/input/InputNumber.tsx 86.66% <66.66%> (ø)
packages/components/src/components/tag/Tag.tsx 86.95% <72.72%> (-13.05%) ⬇️
...mponents/src/components/date-picker/datePicker.tsx 74.07% <74.07%> (ø)
...ages/components/src/components/modal/StepModal.tsx 72.05% <83.33%> (-0.08%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b29146...33f572a. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-228--gio-design.surge.sh

@phyzess phyzess merged commit 6db7118 into growingio:master Sep 17, 2020
@LEEHONCN LEEHONCN deleted the input-fix branch November 4, 2020 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Input] value and onChange shouldn't must have.
2 participants