Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix on demand loading bug #253

Merged
merged 1 commit into from
Sep 24, 2020
Merged

fix: fix on demand loading bug #253

merged 1 commit into from
Sep 24, 2020

Conversation

phyzess
Copy link
Contributor

@phyzess phyzess commented Sep 24, 2020

affects: @gio-design/components

Related issue link

Changelog

Language Changelog
🇺🇸 English fix some components can't be loaded on demand bug.
🇨🇳 Chinese 修复部分组件无法按需加载问题。

Self check

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

affects: @gio-design/components
@codecov
Copy link

codecov bot commented Sep 24, 2020

Codecov Report

Merging #253 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   62.93%   62.93%           
=======================================
  Files          95       95           
  Lines        2763     2763           
  Branches      687      687           
=======================================
  Hits         1739     1739           
  Misses       1020     1020           
  Partials        4        4           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fcfc9e...54f5572. Read the comment docs.

@azure-pipelines
Copy link

Deploy preview for ready! ✅ https://deploy-preview-253--gio-design.surge.sh

@Danny548326 Danny548326 merged commit b30d271 into growingio:master Sep 24, 2020
@phyzess phyzess deleted the fix-load-ondemand branch November 2, 2020 03:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants