GrowthBook Types system #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I like this solution way better than the recent JsonElement change. |
# Conflicts: # GrowthBook/src/jvmTest/kotlin/com/sdk/growthbook/tests/GBExperimentRunTests.kt
madhuchavva
reviewed
Jan 6, 2025
|
|
||
| /** | ||
| * Feature Evaluator Class | ||
| * Takes Context and Feature Key | ||
| * Returns Calculated Feature Result against that key | ||
| */ | ||
| internal class GBFeatureEvaluator { | ||
| internal class GBFeatureEvaluator( | ||
| private val context: GBContext, |
There was a problem hiding this comment.
Let us not tie in FeatureEvaluator to context. We're moving away from this approach.
We'd want the Growthbook instance be decoupled from the context, use an evaluation context for feature eval operations. See the recent changes made to support multi-context in java sdk for more details.
…uation context for feature eval operations.
|
I'm not able to review this, but @madhuchavva or @bryce-fitzsimons are probably the best people to do so. |
madhuchavva
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GrowthBook Console proposes Boolean, String, Number and JSON types for features:
In this PR getting specified feature type instead of
JsonElementwas implemented: