Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go modules support #185

Closed
lopezator opened this issue Jan 15, 2019 · 3 comments
Closed

go modules support #185

lopezator opened this issue Jan 15, 2019 · 3 comments

Comments

@lopezator
Copy link

lopezator commented Jan 15, 2019 •
edited
Loading

Add support for GO modules.

As the current https://github.com/grpc-ecosystem/go-grpc-middleware/blob/master/.travis.yml supports go 1.8.x does this feels enough to launch a new major release?

Maybe v1.1.0?

CC/ @domgreen @mwitkow
lopezator added a commit to lopezator/go-grpc-middleware that referenced this issue Jan 15, 2019
@lopezator
modules: Add modules support
e88ad94 
Add modules support. Closes grpc-ecosystem#185
@lopezator lopezator mentioned this issue Jan 15, 2019
Closed
@hexfusion hexfusion mentioned this issue Jan 29, 2019
Closed
@bcessa bcessa mentioned this issue Apr 19, 2019
Closed
@mrxliu
Copy link

mrxliu commented Apr 20, 2019

verifying github.com/grpc-ecosystem/[email protected]/go.mod: checksum mismatch
downloaded: h1:FiyG127CGDf3tlThmgyCl78X/SZQqEOJBCDaAfeWzPs=
go.sum: h1:Iju5GlWwrvL6UBg4zJJt3btmonfrMlCDdsejg4CZE7c=

@yankooo
Copy link

yankooo commented Jun 5, 2019 •
edited
Loading

I can't use go module to sync import "github.com/grpc-ecosystem/go-grpc-middleware/ratelimit". Is it because the ratelimitpackage was updated yesterday?

@domgreen
Copy link
Contributor

Have moved from dep to go mod ... @mrxliu @yankooo does this help with your issue?

Closing this Issue if not fixed lets raise a new one for specific problems that are being noticed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

modules: Add modules support lopezator/go-grpc-middleware
4 participants
@domgreen @mrxliu @lopezator @yankooo