This repository has been archived by the owner on Apr 18, 2023. It is now read-only.
update README with non-deprecated promhttp Handler #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `http.Handler()` is deprecated per [golang client http.go comment](https://github.com/prometheus/client_golang/blob/master/prometheus/http.go#L63-L66): ``` // Deprecated: Please note the issues described in the doc comment of // InstrumentHandler. You might want to consider using promhttp.Handler instead // (which is not instrumented, but can be instrumented with the tooling provided // in package promhttp). ``` Update README to recommend non-deprecated [Handler from promhttp](https://github.com/prometheus/client_golang/blob/master/prometheus/promhttp/http.go#L77).
Codecov Report
@@ Coverage Diff @@
## master #21 +/- ##
=======================================
Coverage 82.66% 82.66%
=======================================
Files 7 7
Lines 248 248
=======================================
Hits 205 205
Misses 35 35
Partials 8 8Continue to review full report at Codecov.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
http.Handler()is deprecated per golang client http.go comment:Update README to recommend non-deprecated Handler from promhttp.