Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generated code has a data race #123

Closed
ttvtelepresence opened this issue Mar 3, 2016 · 0 comments
Closed

generated code has a data race #123

ttvtelepresence opened this issue Mar 3, 2016 · 0 comments

Comments

@ttvtelepresence
Copy link

ctx is overwritten while a goroutine could possibly read from it, breaking go test -race. You can reproduce by simply running go test -race ./... from the repository's base directory.
the read is here and the write is here

This can be fixed by using a differently named variable here instead of overwriting ctx and changing its subsequent usage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant