Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

protoc-gen-openapiv2 rule should expose all of the relevant flags available #1831

Closed
zoido opened this issue Nov 21, 2020 · 0 comments · Fixed by #1832
Closed

protoc-gen-openapiv2 rule should expose all of the relevant flags available #1831

zoido opened this issue Nov 21, 2020 · 0 comments · Fixed by #1832

Comments

@zoido
Copy link
Contributor

zoido commented Nov 21, 2020

🚀 Feature

protoc-gen-openapiv2 Bazel rule should allow to set all of the generation options that area available to the generator itself.
.
This would allow to fully tune the behavior even when used withing the Bazel pipeline
@zoido zoido mentioned this issue Nov 21, 2020
Merged
johanbrandhorst added a commit that referenced this issue Nov 21, 2020
@zoido @johanbrandhorst
Rest protoc-gen-openapiv2 flags as rule attrs (#1832)
370d869 
* Rest protoc-gen-openapiv2 flags as rule attrs

Exposes rest of the protoc-gen-openapiv2 flags as attributes
in the Baze rule.

Additionaly:
 - sorts atttributes according to the order how flags in tha main are defined
 - adds docs to the attrributes

Fixes #1831 

* Apply suggestions from code review

Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>

* REVIEW: change ovelooked copy cat error in the condition

* REVIEW: adjust json_names_for_fields doc

Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rest protoc-gen-openapiv2 flags as rule attrs
1 participant
@zoido