-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix templateToSwaggerPath generates invalid path #1006
Fix templateToSwaggerPath generates invalid path #1006
Conversation
e2d3d23
to
13a4053
Compare
Codecov Report
@@ Coverage Diff @@
## master #1006 +/- ##
=========================================
+ Coverage 53.84% 54% +0.15%
=========================================
Files 42 42
Lines 4147 4170 +23
=========================================
+ Hits 2233 2252 +19
- Misses 1670 1672 +2
- Partials 244 246 +2
Continue to review full report at Codecov.
|
Thanks for this fix! @tlyng Can you confirm this fixes your issue? |
13a4053
to
c11890f
Compare
Bump @tlyng, have you tested this fix? |
@ch3rub1m could you rebase this on master please? Lets get this fix merged. |
Ok, I'll do it. |
c11890f
to
163bea8
Compare
@johanbrandhorst Have done. |
163bea8
to
e6587a2
Compare
@johanbrandhorst Done. |
Thanks for your contribution! |
@johanbrandhorst is a new version of this already merged? Because I am able to reproduce the underlying issue with the latest master. |
No, I don't think it was ever picked up again unfortunately. We'd love to have someone contribute another fix 😄. |
Additional PR for #704 to avoid #1000