Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix templateToSwaggerPath generates invalid path #1006

Merged

Conversation

ch3rub1m
Copy link
Contributor

Additional PR for #704 to avoid #1000

@ch3rub1m ch3rub1m force-pushed the bugfix-invalid-swagger branch from e2d3d23 to 13a4053 Compare August 27, 2019 09:04
@codecov-io
Copy link

codecov-io commented Aug 27, 2019

Codecov Report

Merging #1006 into master will increase coverage by 0.15%.
The diff coverage is 84%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1006      +/-   ##
=========================================
+ Coverage   53.84%     54%   +0.15%     
=========================================
  Files          42      42              
  Lines        4147    4170      +23     
=========================================
+ Hits         2233    2252      +19     
- Misses       1670    1672       +2     
- Partials      244     246       +2
Impacted Files Coverage Δ
protoc-gen-swagger/genswagger/template.go 57.51% <84%> (+0.54%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8115cdb...163bea8. Read the comment docs.

@johanbrandhorst
Copy link
Collaborator

Thanks for this fix!

@tlyng Can you confirm this fixes your issue?

@ch3rub1m ch3rub1m force-pushed the bugfix-invalid-swagger branch from 13a4053 to c11890f Compare August 27, 2019 09:15
@johanbrandhorst
Copy link
Collaborator

Bump @tlyng, have you tested this fix?

@johanbrandhorst
Copy link
Collaborator

@ch3rub1m could you rebase this on master please? Lets get this fix merged.

@johanbrandhorst johanbrandhorst mentioned this pull request Oct 20, 2019
@ch3rub1m
Copy link
Contributor Author

ch3rub1m commented Oct 21, 2019

@ch3rub1m could you rebase this on master please? Lets get this fix merged.

Ok, I'll do it.

@ch3rub1m ch3rub1m force-pushed the bugfix-invalid-swagger branch from c11890f to 163bea8 Compare October 21, 2019 10:51
@ch3rub1m
Copy link
Contributor Author

@johanbrandhorst Have done.

@johanbrandhorst
Copy link
Collaborator

The online ui is still reporting some conflicts, are you sure you pushed it?

image

@ch3rub1m ch3rub1m force-pushed the bugfix-invalid-swagger branch from 163bea8 to e6587a2 Compare October 29, 2019 09:06
@ch3rub1m
Copy link
Contributor Author

ch3rub1m commented Oct 29, 2019

@johanbrandhorst Done.

@johanbrandhorst johanbrandhorst merged commit 6966912 into grpc-ecosystem:master Oct 29, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

@ch3rub1m ch3rub1m deleted the bugfix-invalid-swagger branch October 29, 2019 09:19
@johanbrandhorst
Copy link
Collaborator

Unfortunately this was causing crashes for valid paths (such as get: "/api/v3/availabilityGroup/{xid}/parent"), so I've had to revert this: #1078. @ch3rub1m a new issue is being raised with more details, but we'll need a new version of this in.

@ch3rub1m ch3rub1m restored the bugfix-invalid-swagger branch November 7, 2019 07:34
@BinaryHexer
Copy link

@johanbrandhorst is a new version of this already merged? Because I am able to reproduce the underlying issue with the latest master.

@johanbrandhorst
Copy link
Collaborator

No, I don't think it was ever picked up again unfortunately. We'd love to have someone contribute another fix 😄.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants