-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update ISSUE_TEMPLATE.md #1014
Update ISSUE_TEMPLATE.md #1014
Conversation
Fix minor typo
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1014 +/- ##
=========================================
Coverage ? 53.41%
=========================================
Files ? 40
Lines ? 4038
Branches ? 0
=========================================
Hits ? 2157
Misses ? 1679
Partials ? 202 Continue to review full report at Codecov.
|
💭 There's no trivial fix exception from the CLA, is there? |
Nope, the CLA is mandatory 😬. |
Ooops I forgot to sign the CLA I mean to when I got home a few evenings ago. Done now! :D |
IIRC the CLA will never be checked again, though... @johanbrandhorst am I making this up? |
🤔 maybe I'm wrong: fastlane/fastlane#11122? Edit no idea what I found there -- this is webhook based, so there's probably no way to have the bot recheck: https://opensource.google.com/docs/cla/#verify |
The bot will check the CLA again if the user addresses the bot I think. It's part of the CLA signing instructions. |
We can also manually override the CLA bot. @achew22. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
I just retriggered the bot and it is happy now, but in the future (per the instructions from the bot):
|
Fix minor typo
Fix minor typo