Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ISSUE_TEMPLATE.md #1014

Merged
merged 1 commit into from
Sep 10, 2019
Merged

Update ISSUE_TEMPLATE.md #1014

merged 1 commit into from
Sep 10, 2019

Conversation

prologic
Copy link
Contributor

Fix minor typo

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@a9bbe40). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1014   +/-   ##
=========================================
  Coverage          ?   53.41%           
=========================================
  Files             ?       40           
  Lines             ?     4038           
  Branches          ?        0           
=========================================
  Hits              ?     2157           
  Misses            ?     1679           
  Partials          ?      202

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9bbe40...4de47ff. Read the comment docs.

@srenatus
Copy link
Contributor

💭 There's no trivial fix exception from the CLA, is there?

@johanbrandhorst
Copy link
Collaborator

Nope, the CLA is mandatory 😬.

@prologic
Copy link
Contributor Author

Ooops I forgot to sign the CLA I mean to when I got home a few evenings ago. Done now! :D

@srenatus
Copy link
Contributor

IIRC the CLA will never be checked again, though... @johanbrandhorst am I making this up?

@srenatus
Copy link
Contributor

srenatus commented Sep 10, 2019

🤔 maybe I'm wrong: fastlane/fastlane#11122?

Edit no idea what I found there -- this is webhook based, so there's probably no way to have the bot recheck: https://opensource.google.com/docs/cla/#verify

@johanbrandhorst
Copy link
Collaborator

The bot will check the CLA again if the user addresses the bot I think. It's part of the CLA signing instructions.

@johanbrandhorst
Copy link
Collaborator

We can also manually override the CLA bot. @achew22.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@achew22
Copy link
Collaborator

achew22 commented Sep 10, 2019

I just retriggered the bot and it is happy now, but in the future (per the instructions from the bot):

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

@achew22 achew22 merged commit d818363 into grpc-ecosystem:master Sep 10, 2019
adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants