Emit error on HTTP rules without a matching selector and log warning on unbound methods

[andrascz]

Fixes #1175

I could not emit error in case of unbound methods as that would have break all the examples.

[googlebot]

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

---

What to do if you already signed the CLA

Individual signers

• It's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.

Corporate signers

• Your company has a Point of Contact who decides which employees are authorized to participate. Ask your POC to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the Google project maintainer to go/cla#troubleshoot (Public version).
• The email used to register you as an authorized contributor must be the email used for the Git commit. Check your existing CLA data and verify that your email is set on your git commits.
• The email used to register you as an authorized contributor must also be attached to your GitHub account.

ℹ️ Googlers: Go here for more info.

[johanbrandhorst]

Excellent work! What does this it look like when you run it and there's a route mismatch?

[andrascz]

Excellent work! What does this it look like when you run it and there's a route mismatch?

In case of grpc method without HTTP rule:

W0317 16:42:06.689825  444590 services.go:38] No HttpRule found for method: CastleblackService.GetHealth

In case of HTTP Rule without matching grpc method:

--grpc-gateway_out: HTTP rules without a matching selector: .pb.CastleblackService.GetHealthz
make: *** [makefiles/protobuf.mk:18: pkg/pb] Error 1

[andrascz]

We submitted the CLA, but not yet processed I guess, I will check daily and update when there is progress.

[johanbrandhorst]

We submitted the CLA, but not yet processed I guess, I will check daily and update when there is progress.

You trigger a check manually:

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

[andrascz]

You trigger a check manually:

Thanks, I know that, but the CLA page does not show me as signed yet and according to the doc:

If the contributor is covered by a corporate CLA, make sure that the corporation is listed at http://linkremoved/. If it’s not, it simply may not have been processed yet, which typically takes a few days.

[johanbrandhorst]

My bad!

[andrascz]

@googlebot I signed it!

[googlebot]

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

[johanbrandhorst]

Thanks for your contribution! A pleasure working with you 😁

[yousseftelda]

@johanbrandhorst What is rationale behind the warning on unbound methods? This produces a lot of warnings as we only want to generate a gateway for a subset of our gRPC services.
Can we put this behind a flag? Happy to open a PR.

[johanbrandhorst]

I'd be happy to remove the unbound method warning, it's much less likely to be unintentional than the HTTP route mismatch. Does that sound okay @andrascz?

[andrascz]

Sure, it seems reasonable to make this configurable.