-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace our own custom option with the one defined by Google #12
Merged
Merged
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
ea9f6ac
Import a definition of a custom option from github.com/google/googleapis
yugui 9bf40a9
Generate Go files from the new annotation .proto files.
yugui d08615b
Implement runtime pattern matcher
yugui ae7afe3
Support verb part of the template pattern
yugui 3daa1df
Add String() to runtime.Pattern.
yugui a8d4491
Export opcodes in internal/ package.
yugui e407fb1
Add path template parser
yugui 34560be
Implement compiler from AST to opcodes
yugui 2b41609
Fix golint and go tool vet errors
yugui 0ad57f7
Export bound fields from httprule.Template
yugui d8bcb11
Add Pattern-based request multiplexer
yugui f709571
Add intermediate representation of services and messages
yugui af1c482
Reimplement code generator with httprule and descriptor packages.
yugui 5783729
Update examples with the new protoc plugin
yugui 85ef5cf
Deprecate the old custom option
yugui 415c655
Update README.md
yugui 9b048b1
Extract go package reservation from descriptor loader to code generator
yugui 8cfb28f
Remove test files from the list of plugin sources
yugui b807c97
Renumber an ordered list
yugui d8399af
Fix golint and go vet errors in runtime/
yugui a584b49
Fix a golint error in internal/
yugui adba95a
Fix golint and go vet errrors in descriptor/
yugui 8308b8f
Fix golint and go vet errors in gengateway
yugui 169d51e
Fix go vet errors in generated codes
yugui 17fee9f
Merge branch 'master' into feature/google-http-rule
yugui 593bfcc
Adjust log verbosity
yugui 0691d05
Correct example codes
yugui 9b03271
Remove decoder configurtion from descriptor.Body
yugui 334e625
Update README.md
yugui File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One too many
n
's in annotationsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done. thx