Consolidate error handling configuration #1265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanbrandhorst
commented
May 2, 2020
johanbrandhorst
commented
May 2, 2020
|
@jgiles I would appreciate your thoughts on this redesign as a user. |
johanbrandhorst
force-pushed
the
consolidate-error-handling-configuration
branch
from
e4b06d2 to
fdc7157
Compare
|
This will need documentation changes |
Codecov Report
@@ Coverage Diff @@
## v2 #1265 +/- ##
==========================================
+ Coverage 54.01% 54.48% +0.47%
==========================================
Files 42 41 -1
Lines 4360 4311 -49
==========================================
- Hits 2355 2349 -6
+ Misses 1747 1707 -40
+ Partials 258 255 -3
Continue to review full report at Codecov.
|
johanbrandhorst
force-pushed
the
consolidate-error-handling-configuration
branch
from
fdc7157 to
245b80d
Compare
jhump
reviewed
May 4, 2020
johanbrandhorst
force-pushed
the
consolidate-error-handling-configuration
branch
2 times, most recently
from
96ee615 to
89f6a52
Compare
All unary and streaming error responses are now handled with a single function each, and are configured in a single place.
johanbrandhorst
force-pushed
the
consolidate-error-handling-configuration
branch
from
89f6a52 to
129822a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All unary responses are now handled with a single function,
and are configured in a single place.
Would appreciate some feedback on this as it removes a lot of API.