-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
protoc-gen-swagger, Fix for infinite loop on circular references in query parameters #1266
protoc-gen-swagger, Fix for infinite loop on circular references in query parameters #1266
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Codecov Report
@@ Coverage Diff @@
## master #1266 +/- ##
==========================================
+ Coverage 53.99% 54.14% +0.15%
==========================================
Files 42 42
Lines 4369 4375 +6
==========================================
+ Hits 2359 2369 +10
+ Misses 1752 1750 -2
+ Partials 258 256 -2
Continue to review full report at Codecov.
|
@googlebot I signed it! |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
@googlebot I fixed it. |
@googlebot I fixed it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fantastic! Thanks so much for putting this together, and I love your comments. A+, I've only got some grammatical comments, I think the more commonly used phrase for this sort of thing is cycle
, so I've made some suggestions. Thanks for your contribution!
…ng track of and detecting circular references. Added test TestMessageToQueryParametersRecursive for testing gracefully handling of circular references between messages. See issue grpc-ecosystem#1167
50ae79d
to
02f5169
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
245886a
to
ded59b5
Compare
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Hmm... I seem to continuously run into issues with cla/google. It does not like my setup with multiple email accounts... but i think i have managed to get it working. I have accepted all your requested changed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a missed a few circle references, sorry!
Thanks for your contribution! Could you please cherry pick this commit to v2? |
… parameters (grpc-ecosystem#1266) * Added function nestedQueryParams with map[string] parameter for keeping track of and detecting circular references. Added test TestMessageToQueryParametersRecursive for testing gracefully handling of circular references between messages. See issue grpc-ecosystem#1167 * Code-review change requests accepted * More missed circle references changed to cycle Fixes grpc-ecosystem#1167
Added function nestedQueryParams in proto-gen-swagger/genswagger/template.go with map[string]bool parameter for keeping track of and detecting circular references.
Added test TestMessageToQueryParametersRecursive in proto-gen-swagger/genswagger/template_test.go for testing gracefully handling of circular references between messages.
See issue #1167