Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in CONTRIBUTING.md #1360

Merged
merged 1 commit into from
May 18, 2020

Conversation

amanjain97
Copy link
Contributor

WHAT

Fixed typo in CONTRIBUTING.md file

Previous

Great, it should be as simple as thus

After

Great, it should be as simple as this

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@amanjain97
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@achew22
Copy link
Collaborator

achew22 commented May 18, 2020

@amanjain97 thanks so much for your contribution!

@achew22 achew22 merged commit b7cf781 into grpc-ecosystem:master May 18, 2020
@johanbrandhorst
Copy link
Collaborator

Hey @amanjain97, could you please cherry pick this against v2?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants