Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove usage of deprecated grpc.Errorf API #1380

Merged
merged 1 commit into from
May 23, 2020
Merged

Remove usage of deprecated grpc.Errorf API #1380

merged 1 commit into from
May 23, 2020

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented May 23, 2020

Remove usage of deprecated grpc.Errorf API.

johanbrandhorst
johanbrandhorst approved these changes May 23, 2020
View reviewed changes
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@codecov-commenter
Copy link

Codecov Report

Merging #1380 into master will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1380   +/-   ##
=======================================
  Coverage   54.14%   54.14%           
=======================================
  Files          42       42           
  Lines        4375     4375           
=======================================
  Hits         2369     2369           
  Misses       1750     1750           
  Partials      256      256
Impacted Files Coverage Δ
protoc-gen-grpc-gateway/descriptor/types.go 41.08% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9f8a34...76afc4f. Read the comment docs.

@johanbrandhorst johanbrandhorst merged commit 690734d into grpc-ecosystem:master May 23, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks, could you please cherry pick this against v2?

@bvwells
Copy link
Contributor Author

bvwells commented May 23, 2020

@johanbrandhorst thanks for the super fast review! Will cherry pick it now.

@bvwells bvwells mentioned this pull request May 23, 2020
Merged
@bvwells bvwells deleted the grpc-deprecated branch May 23, 2020 17:59
johanbrandhorst pushed a commit that referenced this pull request May 23, 2020
@bvwells
Remove usage of deprecated grpc.Errorf API (#1380) (#1382)
560f0a4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanbrandhorst johanbrandhorst johanbrandhorst approved these changes

Assignees
No one assigned
Labels
cla: yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bvwells @codecov-commenter @johanbrandhorst @googlebot