Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: make HTTPBodyMarshaler the default #1385

Merged
merged 1 commit into from
May 23, 2020

Conversation

johanbrandhorst
Copy link
Collaborator

google.api.HttpBody provides complete control over
the output format and content type, and we should
support this natively in the gateway, and not force
users to set their marshaler explicitly.

@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

Codecov Report

Merging #1385 into v2 will increase coverage by 0.05%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v2    #1385      +/-   ##
==========================================
+ Coverage   58.81%   58.87%   +0.05%     
==========================================
  Files          32       32              
  Lines        3904     3895       -9     
==========================================
- Hits         2296     2293       -3     
+ Misses       1354     1349       -5     
+ Partials      254      253       -1     
Impacted Files Coverage Δ
runtime/marshal_json.go 66.66% <0.00%> (ø)
runtime/marshal_proto.go 55.55% <0.00%> (ø)
runtime/marshaler.go 100.00% <ø> (ø)
runtime/marshaler_registry.go 85.71% <ø> (ø)
runtime/errors.go 48.48% <100.00%> (+1.42%) ⬆️
runtime/handler.go 45.29% <100.00%> (-0.08%) ⬇️
runtime/marshal_httpbodyproto.go 100.00% <100.00%> (+23.07%) ⬆️
runtime/marshal_jsonpb.go 67.74% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 32c7633...f7277b2. Read the comment docs.

google.api.HttpBody provides complete control over
the output format and content type, and we should
support this natively in the gateway, and not force
users to set their marshaler explicitly.
@johanbrandhorst johanbrandhorst force-pushed the make-httpbody-marshaler-default branch from 99234d7 to f7277b2 Compare May 23, 2020 21:20
@johanbrandhorst johanbrandhorst merged commit 885c0bd into v2 May 23, 2020
@johanbrandhorst johanbrandhorst deleted the make-httpbody-marshaler-default branch May 23, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants