Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime: remove DisallowUnknownFields() #1386

Merged
merged 1 commit into from
May 24, 2020

Conversation

johanbrandhorst
Copy link
Collaborator

This is now entirely controlled by the marshaller
options.

This is now entirely controlled by the marshaller
options.
@johanbrandhorst johanbrandhorst force-pushed the remove-disallow-unknown-fields branch from 211e54d to 12f0a6d Compare May 23, 2020 22:09
@codecov-commenter
Copy link

codecov-commenter commented May 23, 2020

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 58.82%. Comparing base (885c0bd) to head (12f0a6d).

Files with missing lines Patch % Lines
runtime/marshal_jsonpb.go 83.33% 0 Missing and 2 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #1386      +/-   ##
==========================================
- Coverage   58.87%   58.82%   -0.05%     
==========================================
  Files          32       32              
  Lines        3895     3891       -4     
==========================================
- Hits         2293     2289       -4     
  Misses       1349     1349              
  Partials      253      253              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johanbrandhorst johanbrandhorst merged commit ffdd31c into v2 May 24, 2020
@johanbrandhorst johanbrandhorst deleted the remove-disallow-unknown-fields branch May 24, 2020 09:01
@johanbrandhorst johanbrandhorst mentioned this pull request May 24, 2020
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants