Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add openapi protobuf documentation examples #1427

Merged
merged 1 commit into from
Jun 1, 2020
Merged

Add openapi protobuf documentation examples #1427

merged 1 commit into from
Jun 1, 2020

Conversation

bvwells
Copy link
Contributor

@bvwells bvwells commented May 31, 2020

Add some examples of openapi protobuf annotations

@codecov-commenter
Copy link

codecov-commenter commented May 31, 2020

Codecov Report

Merging #1427 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1427   +/-   ##
=======================================
  Coverage   54.24%   54.24%           
=======================================
  Files          42       42           
  Lines        4391     4391           
=======================================
  Hits         2382     2382           
  Misses       1752     1752           
  Partials      257      257           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a91645...e8f5157. Read the comment docs.

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Unfortunately the mixing of tabs and spaces makes it look a bit off, could we use spaces consistently please?

protoc-gen-swagger/options/openapiv2.proto Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst merged commit dcf2f05 into grpc-ecosystem:master Jun 1, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Do you think you could cherry pick this against v2? Note that we changed some package names, and there will probably be some merge conflicts.

@bvwells bvwells deleted the documentation branch June 1, 2020 18:29
@bvwells
Copy link
Contributor Author

bvwells commented Jun 1, 2020

Cherry picked the commit in PR #1429. Thanks for the review and merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants