Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document optional swagger plugin for unannotated grpc_api_configuration #1588

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

piengeng
Copy link
Contributor

add --swagger_out reference to issue #1578

References to other Issues or PRs

Have you read the Contributing Guidelines?

Brief description of what is fixed or changed

Other comments

add `--swagger_out` reference to issue grpc-ecosystem#1578
Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you so much! This will be sure to help other users in the future 😄. Just a few comments.

docs/_docs/grpcapiconfiguration.md Outdated Show resolved Hide resolved
Co-authored-by: Johan Brandhorst-Satzkorn <[email protected]>
@johanbrandhorst johanbrandhorst merged commit f3b7d47 into grpc-ecosystem:master Aug 12, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution! Could you cherry pick this against the v2 branch please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants