Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust protoc-gen-openapiv2/main.go flags docs as suggested during #1832 review #1833

Merged
merged 2 commits into from
Nov 28, 2020
Merged

Conversation

zoido
Copy link
Contributor

@zoido zoido commented Nov 21, 2020

Have you read the Contributing Guidelines?

yes

Brief description of what is fixed or changed

There were bunch stylistic and grammatical suggestions for the parameters docs in the #1832 by @johanbrandhorst.
This PR applies the suggestions also in the protoc-gen-openapiv2/main.go flags description as that;s the place where the text was copied from.

@google-cla google-cla bot added the cla: yes label Nov 21, 2020
@codecov-io
Copy link

Codecov Report

Merging #1833 (d36459f) into master (370d869) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1833   +/-   ##
=======================================
  Coverage   57.39%   57.39%           
=======================================
  Files          34       34           
  Lines        3652     3652           
=======================================
  Hits         2096     2096           
  Misses       1290     1290           
  Partials      266      266           
Impacted Files Coverage Δ
protoc-gen-openapiv2/main.go 24.54% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 370d869...d36459f. Read the comment docs.

@zoido zoido marked this pull request as ready for review November 21, 2020 13:42
protoc-gen-openapiv2/main.go Outdated Show resolved Hide resolved
@johanbrandhorst johanbrandhorst merged commit b9462a0 into grpc-ecosystem:master Nov 28, 2020
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants