-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return codes.InvalidArgument to rather return HTTP 400 instead of HTTP 500 #409
Conversation
Ah...."Waiting for status to be reported", why.... |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
I signed it! |
zzzZZZ |
CLAs look good, thanks! |
ping @tamalsaha , @tmc |
I will close #397 as this PR have test case and examples |
Hi, any comments on this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, @achew22 @tamalsaha one of you want to weigh in?
LGTM. |
1, Same change in "template.go" with #397 .
2, Add a test case.
3, Update examples