Fallback to JSON name when matching URL parameter.

[tgeng]

No description provided.

[tgeng]

Normally proto field names follow snake_case and proto compiler converts them to camel case for JSON mapping. As a result, Rest API clients uses camel cases for json fields when talking to gRPC servers behind the grpc gateway.

This snake_case <-> camelCase conversion is not honored for URL parameters. As a result, client has to use snake_case for URL parameters. This creates an inconsistency between names of JSON objects in HTTP body and names of URL parameters.

[tgeng]

The build failure is caused by the master branch not being updated after the grpc dependency change, which is out of the scope of this change.

[achew22]

Could you add some tests to exercise this behavior and prevent future regressions?

[tgeng]

Thanks achew22! Updated the PR with tests.

[tmc]

Thanks for your contribution! master has a build system fix, can you please rebase this?

[tgeng]

Weird, I am not sure why cla/google check does not go through. I am using my @google account so it should be good. Any idea what might go wrong?

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that they're okay with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

[tgeng]

Hi all, I am guessing an author of this commit might not have signed cla/google. I am a Google employee and this account is associated with my corporate account, so I should not need to sign anything.

[achew22]

Can you rebase your commit off of master so that you no longer have that commit included after grpc-ecosystem/grpc-gateway's master? That should eliminate the warning.

[tgeng]

Hmm it looks like cla/google check is stuck this time. Any suggestions on what I can do next?

[achew22]

I pinged the CLA bot manager and asked him to take a look. If you don't hear back from me by Monday, please ping and we will work it out manually

[tgeng]

Hi achew22, it seems cla/google check is still stuck. Can you take a look? Thanks!!

[achew22]

I just manually verified you have signed the CLA. Sorry about all this. I guess something is wrong with the bot 🤷‍♂️ .

Thanks for your patience and your contribution!

[tgeng]

Wonderful! Thanks!!

…

On Mon, Oct 2, 2017 at 5:07 PM Andrew Z Allen ***@***.***> wrote: Merged #450 <#450>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#450 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AcNsAlaGk3pz3lkU5scypAu-Wywsahisks5soXrSgaJpZM4PJdiX> .