Some steps to fix Travis CI #461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AlekSi have you signed the CLA? |
|
as per #434 this contributor has signed the CLA |
|
Looks like you've previously contributed and everything was good with that, plus the CLA bot is kind of on the fritz. I'm going to merge this. |
tmc
reviewed
Sep 14, 2017
| @@ -28,7 +29,7 @@ script: | |||
| - if (go version | grep -q 1.8) && [ -z "${GATEWAY_PLUGIN_FLAGS}" ]; then test -z "$(git status --porcelain)" || (git status; git diff; exit 1); fi | |||
| - env GLOG_logtostderr=1 go test -race -v github.com/grpc-ecosystem/grpc-gateway/... | |||
| - make lint | |||
| - sh -c 'cd examples/browser && gulp' | |||
| - sh -c 'cd examples/browser && node ./node_modules/gulp/bin/gulp' | |||
tmc
approved these changes
Sep 14, 2017
|
Just to confirm: yes, CLA is signed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notice that Travis CI fails for some time: https://github.com/grpc-ecosystem/grpc-gateway/pulls
That PR allows it to move farther.