Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update to protobuf 1.36.0 and exclude synthetic oneofs during populateFieldValueFromPath #5072

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

aerialls
Copy link
Contributor

@aerialls aerialls commented Dec 17, 2024

References to other Issues or PRs

#5063

Have you read the Contributing Guidelines?

Yes.

Brief description of what is fixed or changed

Add compatibility with protobuf-go >=1.36.0 and changes regarding oneofs for synthetic fields introduced with https://go-review.googlesource.com/c/protobuf/+/632735

Other comments

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, thanks for the PR, is there a test we can add here?

@aerialls aerialls changed the title fix: exclude synthetic oneofs during populateFieldValueFromPath fix: update to protobuf 1.36.0 and exclude synthetic oneofs during populateFieldValueFromPath Dec 18, 2024
@aerialls
Copy link
Contributor Author

I've added a dedicated test in query_test.go with a new optional field. The error is more straight forward this way. I've also updated to protobuf 1.36.0 in the same PR to make sure this is working as expected.

I've validated that without the fix, the test is failing with the following error.

panic: invalid oneof descriptor grpc.gateway.runtime.internal.examplepb.Proto3Message._optional_value for message grpc.gateway.runtime.internal.examplepb.Proto3Message

@johanbrandhorst
Copy link
Collaborator

Thanks a lot, sorry for the noise, could you rebase on main? We had some other dependency changes go in

@johanbrandhorst
Copy link
Collaborator

I force pushed an update, but looks like the bazel tests are still failing. It doesn't look like it's related to your change so I'll try to investigate.

auto-merge was automatically disabled December 19, 2024 11:12

Head branch was pushed to by a user without write access

Copy link
Collaborator

@johanbrandhorst johanbrandhorst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@johanbrandhorst johanbrandhorst merged commit e062b12 into grpc-ecosystem:main Dec 19, 2024
14 checks passed
@johanbrandhorst
Copy link
Collaborator

Thank you for your contribution! I'll get some more dep updates in and cut a release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants