-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update to protobuf 1.36.0 and exclude synthetic oneofs during populateFieldValueFromPath #5072
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the PR, is there a test we can add here?
b4f4142
to
cb75acf
Compare
I've added a dedicated test in I've validated that without the fix, the test is failing with the following error.
|
Thanks a lot, sorry for the noise, could you rebase on main? We had some other dependency changes go in |
cb75acf
to
4aa405d
Compare
I force pushed an update, but looks like the bazel tests are still failing. It doesn't look like it's related to your change so I'll try to investigate. |
…pulateFieldValueFromPath
Head branch was pushed to by a user without write access
4aa405d
to
f72cabc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Thank you for your contribution! I'll get some more dep updates in and cut a release. |
References to other Issues or PRs
#5063
Have you read the Contributing Guidelines?
Yes.
Brief description of what is fixed or changed
Add compatibility with protobuf-go
>=1.36.0
and changes regarding oneofs for synthetic fields introduced with https://go-review.googlesource.com/c/protobuf/+/632735Other comments