-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate import mappings. #635
Conversation
This contains #632 If that is handled, I can rebase this one if needed. |
Codecov Report
@@ Coverage Diff @@
## master #635 +/- ##
=======================================
Coverage 58.94% 58.94%
=======================================
Files 30 30
Lines 2857 2857
=======================================
Hits 1684 1684
Misses 1010 1010
Partials 163 163 Continue to review full report at Codecov.
|
This looks good to me. Let's merge #632, rebase this and then merge. Does that sound okay to you? |
Thanks for the quick review. Will get to it on Wed - tomorrow is public holliday and I am off the computer :) |
Did you have any luck with this? |
Yes, it is still blocked on the discussion in #632. |
That has now been merged. Could you rebase this? |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
Thanks, rebased. |
Instead of generating a list of import paths based on the difnames of the imported protos, generate maps to the package local names. This is needed to handle the case of packages containing a proto with the same name. An example here is the annotation.proto in this module. Fixes grpc-ecosystem#633
CLAs look good, thanks! |
Travis might have some infrastructure failure, I don't see any build output:
|
Instead of generating a list of import paths based on the difnames of the
imported protos, generate maps to the package local names. This is needed to
handle the case of packages containing a proto with the same name.
An example here is the annotation.proto in this module.
Fixes #633