provide access to underlying *json.Decoder from JSONPb.NewDecoder #637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
commented
May 1, 2018
| @@ -84,16 +87,24 @@ func (j *JSONPb) marshalNonProtoField(v interface{}) ([]byte, error) { | |||
| } | |||
|
|
|||
| // Unmarshal unmarshals JSON "data" into "v" | |||
| // Currently it can marshal only proto.Message. | |||
| // TODO(yugui) Support fields of primitive types in a message. | |||
There was a problem hiding this comment.
I removed these lines because they are not true anymore. There are even tests that verify that unmarshaling works for non-proto types.
jhump
force-pushed
the
jh/access-to-underlying-json.decoder
branch
from
25508bd to
5f5bd5c
Compare
Codecov Report
@@ Coverage Diff @@
## master #637 +/- ##
==========================================
+ Coverage 58.88% 58.91% +0.02%
==========================================
Files 30 30
Lines 2853 2855 +2
==========================================
+ Hits 1680 1682 +2
Misses 1010 1010
Partials 163 163
Continue to review full report at Codecov.
|
adasari
pushed a commit
to adasari/grpc-gateway
that referenced
this pull request
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am using the
JSONPbmarshaler in non-grpc-gateway server code to handle a mix of proto and non-proto types for JSON encoding/decoding.I need to be able to control the underlying
*json.Decoder, such as calling itsUseNumber()method and being able to access itsBuffered()data to resume reading from a stream after a JSON value has been decoded from it.