Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the url of gRPC timeouts on README.md #836

Merged
merged 2 commits into from
Dec 26, 2018

Conversation

royeo
Copy link
Contributor

@royeo royeo commented Dec 26, 2018

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@codecov-io
Copy link

codecov-io commented Dec 26, 2018

Codecov Report

Merging #836 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #836   +/-   ##
=======================================
  Coverage   50.22%   50.22%           
=======================================
  Files          39       39           
  Lines        3755     3755           
=======================================
  Hits         1886     1886           
  Misses       1687     1687           
  Partials      182      182

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 719aaad...90cf292. Read the comment docs.

@royeo
Copy link
Contributor Author

royeo commented Dec 26, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@johanbrandhorst
Copy link
Collaborator

Hi @royeo, thanks for spotting this! Could you perhaps even point it at https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#requests to make it even more specific? Thanks!

@royeo
Copy link
Contributor Author

royeo commented Dec 26, 2018

Hi @royeo, thanks for spotting this! Could you perhaps even point it at https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#requests to make it even more specific? Thanks!

Hi @johanbrandhorst , that's really better, I have modified it.

@johanbrandhorst johanbrandhorst merged commit f5e0366 into grpc-ecosystem:master Dec 26, 2018
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants