-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the url of gRPC timeouts on README.md #836
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Codecov Report
@@ Coverage Diff @@
## master #836 +/- ##
=======================================
Coverage 50.22% 50.22%
=======================================
Files 39 39
Lines 3755 3755
=======================================
Hits 1886 1886
Misses 1687 1687
Partials 182 182 Continue to review full report at Codecov.
|
I signed it! |
CLAs look good, thanks! |
Hi @royeo, thanks for spotting this! Could you perhaps even point it at https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md#requests to make it even more specific? Thanks! |
Hi @johanbrandhorst , that's really better, I have modified it. |
Thanks for your contribution! |
The link http://www.grpc.io/docs/guides/wire.html is no longer valid, it should be https://github.com/grpc/grpc/blob/master/doc/PROTOCOL-HTTP2.md .