-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gengateway: allow opting out patch feature #840
gengateway: allow opting out patch feature #840
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny nitpick, looks good overall!
Codecov Report
@@ Coverage Diff @@
## master #840 +/- ##
==========================================
+ Coverage 50.22% 50.46% +0.23%
==========================================
Files 39 39
Lines 3755 3761 +6
==========================================
+ Hits 1886 1898 +12
+ Misses 1687 1681 -6
Partials 182 182
Continue to review full report at Codecov.
|
PTAL @johanbrandhorst, it seems like a bazel test is not passing but i think it's not something related to this change. |
@glerchundi, Yep that is on me. Lemme send a PR to fix Bazel. Sorry about that. |
Thanks Andrew for taking a look. Let me know if something is needed from my
side.
Once merged will appreciate if you can cut a release as this is blocking us
from upgrading (as we thought a minor upgrade would not contain a backward
incompatible change).
…On Tue, 8 Jan 2019 at 00:26, Andrew Z Allen ***@***.***> wrote:
@glerchundi <https://github.com/glerchundi>, Yep that is on me. Lemme
send a PR to fix Bazel. Sorry about that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#840 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ACIPlhn1i1aHinF6PtqfN40cSvinRm3Gks5vA9eqgaJpZM4Z0Ygf>
.
|
#841 should fix that. If you could please rebase it would be hugely appreciated. Thanks! |
@achew22 rebased, lets see :) Thanks! |
Green! thanks @achew22. |
PTAL @johanbrandhorst