-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added WithDisablePathLengthFallback option (to fix issue #447) #855
Added WithDisablePathLengthFallback option (to fix issue #447) #855
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
Codecov Report
@@ Coverage Diff @@
## master #855 +/- ##
==========================================
+ Coverage 51.63% 51.67% +0.03%
==========================================
Files 39 39
Lines 3788 3791 +3
==========================================
+ Hits 1956 1959 +3
Misses 1647 1647
Partials 185 185
Continue to review full report at Codecov.
|
@UladzimirTrehubenka, this looks like a great way to fix it to me! Thanks so much for taking the time to investigate and fix the problem in a way that allows everyone to benefit. Looks like you need to do the CLA, and I'm going to give @johanbrandhorst a chance to look at it also, LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
@UladzimirTrehubenka good to go as soon as you've signed the CLA. |
CLAs look good, thanks! |
See #447