868 improving README with AWS API gateway findings

[fahernandez]

No description provided.

[codecov-io]

Codecov Report

Merging #869 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #869   +/-   ##
=======================================
  Coverage   52.95%   52.95%           
=======================================
  Files          39       39           
  Lines        3907     3907           
=======================================
  Hits         2069     2069           
  Misses       1642     1642           
  Partials      196      196

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 45aec34...ccda42b. Read the comment docs.

[johanbrandhorst]

Hi Fernando! Sorry this hasn't had a review yet, I had an idea! How would you feel about adding this to the docs pages instead of the readme?

[fahernandez]

Hi Fernando! Sorry this hasn't had a review yet, I had an idea! How would you feel about adding this to the docs pages instead of the readme?

Sure, no problem at all! But what you mean with docs pages? Can you share the file path where you consider is a better idea to put it?

[johanbrandhorst]

Look at docs/_docs/patch.md for example. We could add an aws.md which has your tips in it, and we could link to it from index.md. What do you think?

[fahernandez]

Look at docs/_docs/patch.md for example. We could add an aws.md which has your tips in it, and we could link to it from index.md. What do you think?

It seems good to me. Please look at the changes and let me know if it's ok.

[johanbrandhorst]

Just a few grammatical edits, looks good!

[fahernandez]

Typos were fixed as Johan suggested

[johanbrandhorst]

Just discovered a small typo in my own suggestion 😅. Thanks again for this.

[googlebot]

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

Googlers can find more info about SignCLA and this PR by following this link.

[johanbrandhorst]

Ah curses, accepting my own suggesting messes with the CLA. Uhm, let me get back to you on what we can do to fix this.

[fahernandez]

Ah curses, accepting my own suggesting messes with the CLA. Uhm, let me get back to you on what we can do to fix this.

Sorry for that, I thought it was faster only accepting the suggested change.

[johanbrandhorst]

Not your fault, we'll figure this out on our end and get this merged or let you know what needs to be done :).

[googlebot]

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

Googlers can find more info about SignCLA and this PR by following this link.

[johanbrandhorst]

I consent to merging my contribution of this pull request.