-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EOF on send #962
EOF on send #962
Conversation
Co-authored-by: Jonas Arilho <[email protected]>
…plate (#961) Co-authored-by: Jonas Arilho <[email protected]>
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! Just a small question
Looks like you need to regenerate the files too, see the contribution guidelines document. |
The CLA issue can be manually fixed if we can get approval from @jonasarilho your co-author to merge this. A comment in this PR suffices. |
Codecov Report
@@ Coverage Diff @@
## master #962 +/- ##
==========================================
- Coverage 53.26% 53.22% -0.04%
==========================================
Files 40 40
Lines 4001 4004 +3
==========================================
Hits 2131 2131
- Misses 1672 1675 +3
Partials 198 198
Continue to review full report at Codecov.
|
I approve these changes. |
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
Thanks a lot for the contribution! |
* Add integration test for grpc-ecosystem#961 Co-authored-by: Jonas Arilho <[email protected]> * Add verification for io.EOF after stream.Send() on generated code template (grpc-ecosystem#961) Co-authored-by: Jonas Arilho <[email protected]> * Add more values on testABEBulkCreateWithError, run go mod tidy Fixes grpc-ecosystem#961
As we suggested on #961, add a verification for
io.EOF
on the generated code template, along with an integration test