Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(readme): fix typo #965

Merged
merged 1 commit into from
Jul 2, 2019
Merged

Conversation

franxois
Copy link
Contributor

@franxois franxois commented Jul 2, 2019

Fix protoc-gen-swagger binary name in readme.md

Fix `protoc-gen-swagger` binary name in readme.md
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@johanbrandhorst
Copy link
Collaborator

Hi! Thanks for this fix. The test failure was not your fault so I've restarted the test. Could you please follow the instructions to sign the CLA? Thank you.

@codecov-io
Copy link

Codecov Report

Merging #965 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #965   +/-   ##
=======================================
  Coverage   53.22%   53.22%           
=======================================
  Files          40       40           
  Lines        4004     4004           
=======================================
  Hits         2131     2131           
  Misses       1675     1675           
  Partials      198      198

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 740ef2e...f708a2f. Read the comment docs.

@franxois
Copy link
Contributor Author

franxois commented Jul 2, 2019

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Jul 2, 2019
@johanbrandhorst johanbrandhorst merged commit e8ac3c0 into grpc-ecosystem:master Jul 2, 2019
@johanbrandhorst
Copy link
Collaborator

Thanks for your contribution!

adasari pushed a commit to adasari/grpc-gateway that referenced this pull request Apr 9, 2020
Fix `protoc-gen-swagger` binary name in readme.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants