Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTTP Status Code returned for a Failed Precondition error #974

Merged
merged 1 commit into from
Jul 22, 2019

Conversation

cjcormack
Copy link
Contributor

Fixes #972 (and reverses #657). This now returns the semantically correct 400 response, rather than a 412. This matches the gRPC documentation.

Fixes grpc-ecosystem#972 (and reverses grpc-ecosystem#657). This now returns the semantically correct `400` response, rather than a `412`. This matches the gRPC documentation.
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@codecov-io
Copy link

Codecov Report

Merging #974 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #974   +/-   ##
=======================================
  Coverage   53.25%   53.25%           
=======================================
  Files          40       40           
  Lines        4007     4007           
=======================================
  Hits         2134     2134           
  Misses       1675     1675           
  Partials      198      198
Impacted Files Coverage Δ
runtime/errors.go 47.36% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bebc737...7d38558. Read the comment docs.

@cjcormack
Copy link
Contributor Author

Have signed the CLA for my other email address.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@johanbrandhorst johanbrandhorst merged commit f37ac2a into grpc-ecosystem:master Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-standard use of 412 HTTP Status Code
4 participants