Required changes for 3.0.0 preview3 #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JunTaoLuo
commented
Feb 20, 2019
JunTaoLuo
commented
Feb 20, 2019
JunTaoLuo
commented
Feb 20, 2019
test/Grpc.AspNetCore.Server.Tests/GrpcEndpointRouteBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
JunTaoLuo
commented
Feb 20, 2019
davidfowl
reviewed
Feb 20, 2019
src/Grpc.AspNetCore.Server/Internal/HttpContextServerCallContext.cs
Outdated
Show resolved
Hide resolved
JamesNK
reviewed
Feb 20, 2019
src/Grpc.AspNetCore.Server/Internal/HttpContextServerCallContext.cs
Outdated
Show resolved
Hide resolved
test/Grpc.AspNetCore.Server.Tests/GrpcEndpointRouteBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
test/Grpc.AspNetCore.Server.Tests/GrpcEndpointRouteBuilderExtensionsTests.cs
Outdated
Show resolved
Hide resolved
jtattermusch
approved these changes
Feb 20, 2019
There was a problem hiding this comment.
approved, but we need to figure out the question of depending on daily build vs. depending on a released version.
We definitely need a test that makes sure that everything is working against the latest released version (preview2 for now, preview3 soon). I'm not sure about the importance of testing against the unreleased version of .NET core - that depends on how often we will need access to new APIs and fixes (hopefully not often because the thing needs to work for users with preview3 anyway?). If we need both, we should have two tests.
…nsionsTests.cs Co-Authored-By: JunTaoLuo <[email protected]>
…nsionsTests.cs Co-Authored-By: JunTaoLuo <[email protected]>
|
cc @halter73 |
halter73
reviewed
Feb 20, 2019
halter73
approved these changes
Feb 20, 2019
JamesNK
reviewed
Feb 21, 2019
JamesNK
reviewed
Feb 21, 2019
added 3 commits
February 20, 2019 17:09
JamesNK
approved these changes
Feb 21, 2019
natemcmaster
approved these changes
Feb 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few changes in preview3 and updated our code accordingly.