Tweak window sizes to make interop tests pass #154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The fix in dotnet/aspnetcore#8200 will be available in preview 4 so I'm not too concerned with finding an alternative. |
JunTaoLuo
approved these changes
Mar 11, 2019
|
@JunTaoLuo what's the ETA for preview4? |
|
Our preview cadence is about once a month and we just released preview 3 so I'd assume around middle of April. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #149.
I don't like this "fix" at all, because it just masks the fact that Grpc.AspNetCore.Server doesn't work with default params when client sends large messages. The point of "large_unary" test is to test that flow control works as expected (which it currently doesn't by default).
Can we come up with a better fix until dotnet/aspnetcore#8200 is available?