Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: make it possible to configure read and write buffer sizes #5757

Closed
2 tasks done
easwars opened this issue Nov 2, 2022 · 6 comments
Closed
2 tasks done
Assignees

Comments

@easwars
Copy link
Contributor

easwars commented Nov 2, 2022

This issues addresses 2-4 from #5751.

Our benchmarks set server and client write buffer sizes to 128KB.

  • Do not set the read and write buffer sizes by default. Instead let the benchmark client and server use whatever defaults grpc uses.
  • Provide a command line flag to set these buffer sizes.
@atollena
Copy link
Collaborator

atollena commented Nov 2, 2022

#5762 for the first item.

@atollena
Copy link
Collaborator

atollena commented Nov 7, 2022

#5774 -- @easwars I think you can assign this to me, I hope to close this issue with this PR.

@atollena
Copy link
Collaborator

atollena commented Nov 9, 2022

@dfawley any chance you could have a look at the linked PRs #5762 and #5774 when you have time? The first should be a quick one, the second is also probably an easy review.

@easwars easwars added the P2 label Nov 23, 2022
@atollena
Copy link
Collaborator

atollena commented Dec 2, 2022

I think this can be closed since #5774 is merged.

@easwars
Copy link
Contributor Author

easwars commented Dec 2, 2022

Fixed via #5774.

@easwars easwars closed this as completed Dec 2, 2022
@easwars
Copy link
Contributor Author

easwars commented Dec 2, 2022

@atollena Thank you very much for your contribution !!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants