Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: add a feature for read and write buffer sizes #5774

Merged
merged 2 commits into from
Nov 30, 2022
Merged

benchmark: add a feature for read and write buffer sizes #5774

merged 2 commits into from
Nov 30, 2022

Conversation

atollena
Copy link
Collaborator

@atollena atollena commented Nov 7, 2022 •
edited by easwars
Loading

The read and write buffer sizes have an impact on performance, but they are currently hard-coded.

This change adds command line flags for running the benchmarks with specific sizes for those buffers.

RELEASE NOTES: none

@atollena atollena mentioned this pull request Nov 7, 2022
Closed
2 tasks
@zasweq zasweq self-requested a review November 8, 2022 18:50
@zasweq zasweq self-assigned this Nov 8, 2022
@zasweq zasweq added this to the 1.52 Release milestone Nov 8, 2022
@easwars easwars assigned atollena and unassigned zasweq Nov 10, 2022
@atollena
benchmark: add a feature for read and write buffer sizes
e7ee70a 
The read and write buffer sizes have an impact on performance, but they are currently hard-coded.

This change adds command line flags for running the benchmarks with specific sizes for those
buffers.
@atollena
benchmark: properly wire client/server read/write buffer sizes
a105ce2
@atollena atollena force-pushed the benchmark-buffer-sizes branch from fc71437 to a105ce2 Compare November 15, 2022 17:38
@easwars easwars assigned easwars and atollena and unassigned atollena and easwars Nov 15, 2022
@easwars easwars assigned easwars and unassigned atollena Nov 23, 2022
easwars
easwars approved these changes Nov 29, 2022
View reviewed changes
benchmark/benchmain/main.go Show resolved Hide resolved
@easwars easwars assigned zasweq and unassigned easwars Nov 29, 2022
@easwars
Copy link
Contributor

easwars commented Nov 29, 2022

@atollena : Apologies for the delayed review.

@zasweq : For second set of eyes.

zasweq
zasweq approved these changes Nov 30, 2022
View reviewed changes
Copy link
Contributor

@zasweq zasweq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for doing this. Read the back and forth, all makes sense to me. Agreed that this code is convoluted.

@zasweq zasweq assigned atollena and unassigned zasweq Nov 30, 2022
@atollena
Copy link
Collaborator Author

@zasweq I don't have permission to merge on the repository, so you actually need to merge the change for me. Thank you!

@zasweq zasweq merged commit 94f0e7f into grpc:master Nov 30, 2022
@zasweq
Copy link
Contributor

zasweq commented Nov 30, 2022

Done :). Thanks for the contribution.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zasweq zasweq zasweq approved these changes

@easwars easwars easwars approved these changes

Assignees

@atollena atollena

Labels
Type: Testing
Projects
None yet
Milestone
1.52 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@atollena @easwars @zasweq