resolver/dns: error if target ends with a colon instead of assuming the default port #2150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuxuan
reviewed
Jun 22, 2018
resolver/dns/dns_resolver.go
Outdated
| @@ -51,7 +51,8 @@ const ( | |||
| ) | |||
|
|
|||
| var ( | |||
| errMissingAddr = errors.New("missing address") | |||
| errMissingAddr = errors.New("dns resolver: missing address") | |||
| errEndsWithColon = errors.New("dns resolver: address ends with colon") | |||
There was a problem hiding this comment.
"::" also ends with colon but it is a valid case.
I think more explanation will be better, may be just add a comment above the definition, like "address ending with a colon that is supposed to be the separator between host and port is not allowed. e.g. "::" is a valid address as it is an IPv6 address(host only) and [::]: is invalid as it ends with a colon as the host and port separator.
There was a problem hiding this comment.
Updated error and added comment. PTAL
lyuxuan
approved these changes
Jun 22, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically this is a behavior change, but any usage of "host:" or ":" should be considered invalid, since dialing a target with a trailing ":" attempts to dial port zero, which is never valid (and we always used to pass the target directly to
net.Dial).In grpc/grpc#15618, the target format will be defined as:
host[:port]-- not:host[:[port]]. (This is potentially subject to change.)