transport: derive transport context from context.Background #2930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
dzbarsky
reviewed
Jul 24, 2019
|
Hey David, sorry about that! I believe I've rebased properly now. |
dfawley
added
the
Type: Performance
canguler
changed the title
|
Hi @JNProtzman, Code looks good. Have you run any benchmarks to validate the performance improvement gained from the removal of the lock contention? It would be nice to see some numbers before merging this. |
|
Hey @canguler, Looks to be nearly a 1% performance increase! If there is a better way to attach output in the future, please let me know :) |
|
You could also use https://github.com/grpc/grpc-go/blob/master/benchmark/benchresult/main.go to compare the old and new numbers side-by-side. |
|
Thanks for the info @easwars! |
|
It looks like you have used a value for 1s for benchTime. Might want to run it with something larger like 30s or 60s to get a better idea. |
|
I've set benchTime to 60s and re-run :) |
|
Can you run benchmarks in streaming and unconstrained streaming modes as well? Thanks! |
|
Here's streaming: and unconstrained: |
|
Hi @JNProtzman, Can you run tests multiple times, say at least 10 each? Because the results are not very clear and I think this may be due to the variance from run to run. |
|
Friendly ping |
|
My apologies for the delay. I've run the requested tests, 10x each. I've attached a zip archive with the output (in .txt files). Please let me know if this works, or if you need further information / test runs. |
canguler
suggested changes
Aug 29, 2019
|
I ran the benchmark on the current results without sync.Once and the previous results before my 2 commits. Here's the result comparisons: |
canguler
approved these changes
Aug 29, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid lock contention by deriving the transport context from context.Background() (without wrapping in a Cancel/Deadline context). This will make canceling a child context not recurse into the parent.
#1918