Send go away frame on client transport shutdown #4389
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
added
fixit
Type: Behavior Change
dfawley
reviewed
May 5, 2021
| @@ -861,6 +861,10 @@ func (t *http2Client) Close() error { | |||
| } | |||
| t.mu.Unlock() | |||
| t.controlBuf.finish() | |||
There was a problem hiding this comment.
It's possible this exits while loopywriter is about to write to the connection, I believe.
You may want to add something to loopyWriter.run() that closes a channel / fires an event when it exits via a defer, and then block on that.
There was a problem hiding this comment.
Yeah, this is what I figured. Will get to this after finishing up Easwar's comments on #4387.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #460.