xds/kokoro: install go 1.17, and retry go build #5015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
changed the title
dfawley
approved these changes
Nov 30, 2021
test/kokoro/xds.sh
Outdated
| @@ -13,7 +13,13 @@ shopt -s extglob | |||
| branch="${branch//[[:space:]]}" | |||
| branch="${branch##remotes/origin/}" | |||
| shopt -u extglob | |||
| go build | |||
| # Install go >= 1.14 for the new features, e.g. errors.Is() | |||
There was a problem hiding this comment.
This comment will be outdated eventually.
How about "Install a version of Go supported by gRPC"?
There was a problem hiding this comment.
Updated
Or you didn't want that e.g.?
test/kokoro/xds.sh
Outdated
| wget https://go.dev/dl/go1.17.3.linux-amd64.tar.gz | ||
| sudo tar -C /usr/local -xvf go1.17.3.linux-amd64.tar.gz | ||
| sudo cp /usr/local/go/bin/go /usr/bin/go | ||
| # Retry go build on error, for at most 3 times |
There was a problem hiding this comment.
Mention why? (Downloading dependencies, presumably?)
dfawley
reviewed
Nov 30, 2021
test/kokoro/xds.sh
Outdated
Comment on lines
18
to
19
| sudo apt-get install -y wget | ||
| wget https://go.dev/dl/go1.17.3.linux-amd64.tar.gz |
There was a problem hiding this comment.
if curl is already in the VM, it would be preferable to use it. Otherwise this apt install is another potential point of failure.
Also, should these things be retried for the same reason as go build?
dfawley
approved these changes
Nov 30, 2021
test/kokoro/xds.sh
Outdated
| # errors.Is() | ||
| curl --retry 3 -O -L https://go.dev/dl/go1.17.3.linux-amd64.tar.gz | ||
| sudo tar -C /usr/local -xvf go1.17.3.linux-amd64.tar.gz | ||
| sudo cp /usr/local/go/bin/go /usr/bin/go |
There was a problem hiding this comment.
sudo ln -s /usr/local/go/bin/go /usr/bin/go? Seems like it should work, but not 100% sure.
menghanl
changed the title
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Apr 1, 2022
menghanl
added a commit
to menghanl/grpc-go
that referenced
this pull request
Apr 1, 2022
menghanl
added a commit
that referenced
this pull request
Apr 1, 2022
menghanl
added a commit
that referenced
this pull request
Apr 1, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELEASE NOTES: N/A