Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds/priority: log warnings instead of errors #5185

Merged
merged 1 commit into from
Feb 4, 2022
Merged

xds/priority: log warnings instead of errors #5185

merged 1 commit into from
Feb 4, 2022

Conversation

menghanl
Copy link
Contributor

@menghanl menghanl commented Feb 4, 2022

Those are not error logs, and can happen in races. They could confuse the users.

RELEASE NOTES: N/A

@menghanl menghanl requested a review from dfawley February 4, 2022 18:50
@menghanl menghanl added the Type: Internal Cleanup Refactors, etc label Feb 4, 2022
@menghanl menghanl added this to the 1.45 Release milestone Feb 4, 2022
@dfawley dfawley assigned menghanl and unassigned dfawley Feb 4, 2022
@menghanl menghanl merged commit 9196715 into grpc:master Feb 4, 2022
@menghanl menghanl deleted the priority_log branch February 4, 2022 21:01
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

@easwars easwars easwars approved these changes

Assignees

@menghanl menghanl

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.45 Release
Development

Successfully merging this pull request may close these issues.
3 participants
@menghanl @easwars @dfawley