Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace deprecated package && fix naming && fix typo #5740

Closed
wants to merge 1 commit into from

Conversation

korableg
Copy link

@korableg korableg commented Oct 25, 2022

Hello I've replaced github.com/golang/protobuf/proto to google.golang.org/protobuf/proto cause the linters on my project swears on deprecated dependency if I use status.WithDetails in a separate method with a proto.Message arg.

Have a nice day!

RELEASE NOTES: n/a

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Oct 25, 2022

CLA Missing ID CLA Not Signed

@korableg korableg force-pushed the master branch 2 times, most recently from 5c6add6 to 0a9b997 Compare October 25, 2022 02:24
@korableg korableg marked this pull request as draft October 25, 2022 15:34
@korableg korableg marked this pull request as ready for review October 25, 2022 15:34
@korableg korableg marked this pull request as draft October 25, 2022 15:34
@dfawley
Copy link
Member

dfawley commented Oct 25, 2022

I'm fairly sure this is an API-breaking change, as the new proto.Message is not backward compatible with the old proto.Message:

I.e. in https://pkg.go.dev/google.golang.org/protobuf/proto#Message:

This is the v2 interface definition for protobuf messages. The v1 interface definition is "github.com/golang/protobuf/proto".Message.

To convert a v1 message to a v2 message, use "github.com/golang/protobuf/proto".MessageV2. To convert a v2 message to a v1 message, use "github.com/golang/protobuf/proto".MessageV1.

See also #4330

@dfawley
Copy link
Member

dfawley commented Oct 25, 2022

See also golang/protobuf#1442, which has stalled. I believe that needs to be resolved before we can implement this.

@korableg
Copy link
Author

@dfawley Thanks!)

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants