Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply "status: fix/improve status handling (#6662)" (#6673) #6688

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 4, 2023

This reverts commit 9e1fc3e.

It removes the part of the commit that forces status codes out of range to be converted to UNKNOWN, however.

(relnotes from previous PR)
RELEASE NOTES: none

@dfawley dfawley added the Type: Feature New features or improvements in behavior label Oct 4, 2023
@dfawley dfawley added this to the 1.59 Release milestone Oct 4, 2023
@dfawley dfawley requested a review from easwars October 4, 2023 22:05
@easwars easwars assigned dfawley and unassigned easwars Oct 4, 2023
This reverts commit 9e1fc3e.

It removes the part of the commit that forces status codes out of range to be
converted to UNKNOWN, however.
@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #6688 (12727c3) into master (696faa9) will decrease coverage by 0.13%.
The diff coverage is 95.38%.

Additional details and impacted files

@dfawley dfawley merged commit e3f1514 into grpc:master Oct 5, 2023
1 check passed
@dfawley dfawley deleted the status2 branch October 5, 2023 15:20
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Feature New features or improvements in behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants