Skip to content

Commit

Permalink
Establish a default connect timeout. (#11359)
Browse files Browse the repository at this point in the history
Enables the timer added in #11137
  • Loading branch information
jdcormie authored Jul 9, 2024
1 parent 0ff3f8e commit 21dec30
Showing 1 changed file with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,7 @@ public static final class Builder implements ClientTransportFactoryBuilder {
BindServiceFlags bindServiceFlags = BindServiceFlags.DEFAULTS;
InboundParcelablePolicy inboundParcelablePolicy = InboundParcelablePolicy.DEFAULT;
OneWayBinderProxy.Decorator binderDecorator = OneWayBinderProxy.IDENTITY_DECORATOR;
long readyTimeoutMillis = -1; // TODO(jdcormie) Set an non-infinite default in a separate PR.
long readyTimeoutMillis = 60_000;

@Override
public BinderClientTransportFactory buildClientTransportFactory() {
Expand Down Expand Up @@ -210,7 +210,7 @@ public Builder setBinderDecorator(OneWayBinderProxy.Decorator binderDecorator) {
* <a href="https://github.com/grpc/grpc/blob/master/doc/wait-for-ready.md">fail-fast</a> work
* as expected despite certain edge cases that could otherwise stall the transport indefinitely.
*
* <p>Optional. Use a negative value to wait indefinitely.
* <p>Optional but enabled by default. Use a negative value to wait indefinitely.
*/
public Builder setReadyTimeoutMillis(long readyTimeoutMillis) {
this.readyTimeoutMillis = readyTimeoutMillis;
Expand Down

0 comments on commit 21dec30

Please sign in to comment.