netty: Add option to limit RST_STREAM rate #10675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The behavior purposefully mirrors that of Netty's AbstractHttp2ConnectionHandlerBuilder.decoderEnforceMaxRstFramesPerWindow(). That API is not available to our code as we extend the Http2ConnectionHandler, but we want our API to be able to delegate to Netty's in the future if that ever becomes possible.
ejona86
added
the
TODO:backport
YifeiZhuang
approved these changes
Nov 17, 2023
temawi
reviewed
Nov 17, 2023
Comment on lines
547
to
558
| if (maxRstCount > 0) { | ||
| long now = System.nanoTime(); | ||
| if (now - lastRstNanoTime > maxRstPeriodNanos) { | ||
| lastRstNanoTime = now; | ||
| rstCount = 1; | ||
| } else { | ||
| rstCount++; | ||
| if (rstCount > maxRstCount) { | ||
| throw Http2Exception.connectionError(Http2Error.ENHANCE_YOUR_CALM, "too_many_rststreams"); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Extract this logic to a method? Would keep this method more concise and a well named new method would also communicate what this logic is for. Or a comment, as an alternative.
There was a problem hiding this comment.
"Enforce maxRstCount" as a comment seems a bit repetitive. And the description of how this should work is in the public documentation. Do you have an idea for something in particular that is helpful to communicate?
There was a problem hiding this comment.
I guess I was just looking for something to indicate this block of code IS the maxRstCount enforcement. But I don't feel strongly about it.
temawi
approved these changes
Nov 17, 2023
This was referenced Nov 17, 2023
ejona86
removed
the
TODO:backport
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior purposefully mirrors that of Netty's
AbstractHttp2ConnectionHandlerBuilder.decoderEnforceMaxRstFramesPerWindow(). That API is not available to our code as we extend the Http2ConnectionHandler, but we want our API to be able to delegate to Netty's in the future if that ever becomes possible.
CC @temawi