Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

util:Remove Unused experimental API ManagedChannelBuilder.enableFullStreamDecompression #10744

Merged

Conversation

larry-safran
Copy link
Contributor

@larry-safran larry-safran commented Dec 12, 2023

Remove unused experimental method. This is a no-op, since it was never implemented on the server side.

Fixes #3399

@larry-safran larry-safran marked this pull request as ready for review December 12, 2023 02:45
@larry-safran larry-safran requested a review from temawi December 12, 2023 02:46
Copy link
Contributor

@temawi temawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also update the PR description to include why this is being removed? "No-op, since never implemented on the server side..." or something to that effect.

@larry-safran larry-safran merged commit e562a05 into grpc:master Dec 12, 2023
14 checks passed
@larry-safran larry-safran deleted the enableFullStreamDecompression branch December 12, 2023 22:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tracking issue for full-stream compression being experimental
2 participants