Add unit test coverage for PendingAuthListener. #10806
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This class was supposedly already tested via `ServerSecurityPolicyTest.java`, thought that class is actually triggering the short-circuit codepaths (thus, test coverage is reported at 0%). After this PR, I shall send another one to adapt those tests to force the non-short-circuit async path. Part of grpc#10566.
jdcormie
reviewed
Jan 8, 2024
binder/src/test/java/io/grpc/binder/internal/PendingAuthListenerTest.java
Outdated
Show resolved
Hide resolved
jdcormie
reviewed
Jan 8, 2024
binder/src/test/java/io/grpc/binder/internal/PendingAuthListenerTest.java
Outdated
Show resolved
Hide resolved
jdcormie
approved these changes
Jan 8, 2024
markb74
approved these changes
Jan 16, 2024
markb74
added
the
kokoro:run
grpc-kokoro
removed
the
kokoro:run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This class was supposedly already tested via
ServerSecurityPolicyTest.java, thought that class is actually triggering the short-circuit codepaths (thus, test coverage is reported at 0%).After this PR, I shall send another one to adapt those tests to force the non-short-circuit async path.
Part of #10566.