Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Happy Eyeballs by default #11022

Merged
merged 5 commits into from
Mar 21, 2024

Conversation

larry-safran
Copy link
Contributor

No description provided.

try {
synchronizationContext = helper.getSynchronizationContext();
} catch (NullPointerException e) {
// If we have a test helper or old helper without a context, we can't schedule a task
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the test instead of the code?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did fix the tests to provide a synchronization context, but customers could be relying on an old helper that they don't expect to suddenly start failing, so we need to handle the case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test I can believe it can be not implemented. But don't mention "test helper" in code comment.
The LB helper should always have getSynchronizationContext(), from the customer. Originally it is from ManagedChannelImpl. Where is the old helper that does not have this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated the comment. Despite not having any known examples that are not providing the sync context I don't want to break something unknown out in the wild.

@larry-safran larry-safran merged commit 51f811d into grpc:master Mar 21, 2024
14 of 15 checks passed
@larry-safran larry-safran deleted the enable_happy_eyeballs branch March 21, 2024 23:59
@larry-safran larry-safran added this to the 1.63 milestone Mar 22, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants