binder: Simplify ownership of ServerAuthInterceptor's executor. #11293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let BinderServer own this executor directly, between start() and onTerminated(). Allocating it in BinderServerBuilder was convoluted and leaked the Executor if the built server was never actually start()ed.
jdcormie
changed the title
mateusazis
reviewed
Jun 17, 2024
binder/src/main/java/io/grpc/binder/internal/BinderTransportSecurity.java
Outdated
Show resolved
Hide resolved
mateusazis
approved these changes
Jun 17, 2024
ejona86
approved these changes
Jun 19, 2024
larry-safran
pushed a commit
to larry-safran/grpc-java
that referenced
this pull request
Aug 13, 2024
…#11293) Allocating this executor before BinderServer even exists is convoluted and actually leaks if the built server is never actually start()ed. Instead, have BinderServer own this executor directly, with a lifetime from start() until termination. Pass it to the ServerAuthInterceptor via TransportAuthorizationState Attribute instead of at construction time.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allocating this executor before BinderServer even exists is convoluted and actually leaks if the built server is never actually start()ed. Instead, we have BinderServer own this executor directly, with a lifetime from start() until termination. Pass the executor to ServerAuthInterceptor via TransportAuthorizationState Attribute instead of at construction time.